From: | Boszormenyi Zoltan <zb(at)cybertec(dot)at> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Michael Meskes <meskes(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hacker <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: ECPGset_var |
Date: | 2010-01-26 19:46:02 |
Message-ID: | 4B5F467A.2000400@cybertec.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Alvaro Herrera írta:
> Boszormenyi Zoltan wrote:
>
>
>> Thanks for analyzing it, patch is attached. I downloaded
>> and installed ICC, so I could reproduce the difference.
>>
>
> Why not have a single function that does both things in a single call?
> It doesn't look like there's any place that calls the function with only
> one value for "insert" ...
>
Okay, I tried this approach, patch is attached.
This way it doesn't depend on the evaluation order
of function parameters.
> I happened to notice this misleading comment:
>
> char temp[20]; /* this should be sufficient unless you have 8 byte integers */
>
That comment was there before I touched that function, I deleted it now.
There will be other problems before reaching 2^31-1 internal variables,
like compiling the monster C file without the compiler going OOM...
Best regards,
Zoltán Böszörményi
--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics
----------------------------------
Zoltán Böszörményi
Cybertec Schönig & Schönig GmbH
http://www.postgresql.at/
Attachment | Content-Type | Size |
---|---|---|
pg85-fix-ooscope-cur-2-ctxdiff.patch | text/x-patch | 29.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2010-01-26 20:14:42 | Re: ECPGset_var |
Previous Message | Robert Haas | 2010-01-26 19:22:19 | Re: unfathomable comment in psqlscan.l |