| From: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] remove redundant ownership checks |
| Date: | 2009-12-16 06:23:37 |
| Message-ID: | 4B287CE9.606@ak.jp.nec.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
The patch was not attached...
(2009/12/16 15:15), KaiGai Kohei wrote:
> It is a cleanup patch apart from SELinux and security framework.
>
> Now, EnableDisableRule() checks ownership of the relation which
> owns the rewrite rule to be enabled/disabled.
>
> But it has the following call path, and this check is already done
> in the ATPrepCmd().
>
> ATExecCmd()
> -> ATExecEnableDisableRule()
> -> EnableDisableRule()
>
> This patch removes redundant permission checks.
> No need to check same things twice.
>
> Also see the related discussions:
> http://archives.postgresql.org/pgsql-hackers/2009-09/msg01593.php
> http://archives.postgresql.org/pgsql-hackers/2009-09/msg01839.php
> http://archives.postgresql.org/pgsql-hackers/2009-09/msg01840.php
>
> Thanks,
--
OSS Platform Development Division, NEC
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>
| Attachment | Content-Type | Size |
|---|---|---|
| pgsql-fix-enable_disable_rule.patch | text/x-patch | 806 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2009-12-16 06:36:21 | Re: idea - new aggregates median, listagg |
| Previous Message | KaiGai Kohei | 2009-12-16 06:15:32 | [PATCH] remove redundant ownership checks |