From: | Josh Berkus <josh(at)agliodbs(dot)com> |
---|---|
To: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: COPY WITH CSV FORCE QUOTE * -- REVIEW |
Date: | 2009-07-20 22:57:52 |
Message-ID: | 4A64F670.6060709@agliodbs.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Itagaki-san,
On Apple OS 10.5:
1. new patch applied cleanly
2. new patch built cleanly
3. regression tests pass
4. Tested following operations:
postgres=# COPY marchlog TO '/tmp/marchlog1.csv' with csv header;
COPY 81097
postgres=# COPY marchlog TO '/tmp/marchlog2.csv' with csv header force
quote *;
COPY 81097
postgres=# COPY marchlog TO '/tmp/marchlog3.csv' with csv header force
quote process_id;
COPY 81097
postgres=# COPY marchlog TO '/tmp/marchlog4.csv' with csv force quote *;
COPY 81097
postgres=# COPY marchlog TO '/tmp/marchlog5.csv' with force quote *;
ERROR: COPY force quote available only in CSV mode
STATEMENT: COPY marchlog TO '/tmp/marchlog5.csv' with force quote *;
ERROR: COPY force quote available only in CSV mode
postgres=# COPY reloadlog FROM '/tmp/marchlog2.csv' with csv header;
COPY 81097
postgres-# \copy marchlog TO '/tmp/marchlog5.csv' with csv force quote *;
postgres-#
5. Regression tests for FORCE QUOTE present.
6. Docs present; not sure how good they are, see prior discussion.
Stuff someone else should do:
a. review code
b. review code format
I am done with this review.
--
Josh Berkus
PostgreSQL Experts Inc.
www.pgexperts.com
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2009-07-20 22:58:57 | Re: [PATCH v4] Avoid manual shift-and-test logic in AllocSetFreeIndex |
Previous Message | Dean Rasheed | 2009-07-20 22:41:14 | Re: WIP: Deferrable unique constraints |