Skip site navigation (1) Skip section navigation (2)

Peripheral Links

Header And Logo

PostgreSQL
| The world's most advanced open source database.

Site Navigation

Search archives
  Advanced Search

Re: Buglets in dlgFunction


  • From: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
  • To: Dave Page <dpage(at)pgadmin(dot)org>
  • Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
  • Subject: Re: Buglets in dlgFunction
  • Date: Sun, 19 Oct 2008 23:33:21 +0200
  • Message-id: <48FBA7A1.4030401@lelarge.info> <text/plain>

Dave Page a écrit :
> [...]
> Nice work!! So, let's please get this applied so we can put it to bed.
> A couple of minor fixes:
> 
> - In dlgFunction::Go @367, you have:
> 
>     returncode = dlgSecurityProperty::Go(modal);
> 
>     returncode = dlgSecurityProperty::Go(modal);
> 
> Copy/paste error?
> 

Yes. There was also two return statements.

> - Please add a comment to each instance of the ugly resize blocks to
> explain what it's doing so we don't forget in 6 months :-)
> 

Done. Not sure my words are easy to understand. Feel free to change them
to something more appropriate.

Thanks. I still don't like this hack. I hope I'll soon better understand
this issue to replace the ugly code with a good one.


-- 
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com



Home | Main Index | Thread Index

Privacy Policy | About PostgreSQL
Copyright © 1996 – 2012 PostgreSQL Global Development Group