Skip site navigation (1)
Skip section navigation (2)
Peripheral Links
Header And Logo
|
Site Navigation
Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
- To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
- Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Gregory Stark <stark(at)enterprisedb(dot)com>, pgsql-patches(at)postgresql(dot)org, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>, Magnus Hagander <magnus(at)hagander(dot)net>
- Subject: Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- Date: Tue, 25 Mar 2008 16:13:10 +0100
- Message-id: <47E91686.6040800@cybertec.at> <text/plain>
Alvaro Herrera írta:
I don't think my $int64passbyval = "(?($real64 = 1)t|f)"; works. Perhaps my $int64passbyval = $real64 ? 't' : 'f';
Thanks. Modified patch attached. Stupid question follows. Now that float4 is passed by value unconditionally, is it worth modifying the *penalty() functions in GIST/TSearch to just use PG_RETURN_FLOAT4()? Or the implicit "modify the float4 value at the caller site and return the same pointer I got as 3rd parameter" is an internal API set in stone? Modifying them to have only 2 parameters (the 3rd one was an implicit OUT parameter anyway) and omitting the pointer dereference might give a small speedup. -- ---------------------------------- Zoltán Böszörményi Cybertec Schönig & Schönig GmbH http://www.postgresql.at/
Attachment:
pg84-passedbyval-v5.patch.gz
Description: Unix tar archive
- Follow-Ups:
- float4/float8/int64 passed by value with tsearch fixup
- From: Zoltan Boszormenyi
- float4/float8/int64 passed by value with tsearch fixup
- References:
- Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Zoltan Boszormenyi
- int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Zoltan Boszormenyi
- Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Gregory Stark
- Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Zoltan Boszormenyi
- Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Tom Lane
- Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Zoltan Boszormenyi
- Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- From: Alvaro Herrera
- Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- Prev by Date: Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- Next by Date: Re: pg_dump -i wording
- Previous by thread: Re: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
- Next by thread: float4/float8/int64 passed by value with tsearch fixup
- Indexes: