| From: | Dilip kumar <dilip(dot)kumar(at)huawei(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "furuyao(at)pm(dot)nttdata(dot)co(dot)jp" <furuyao(at)pm(dot)nttdata(dot)co(dot)jp> |
| Subject: | Re: pg_xlogdump --stats |
| Date: | 2014-06-30 05:19:10 |
| Message-ID: | 4205E661176A124FAF891E0A6BA913526633730A@szxeml509-mbs.china.huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13 June 2014 13:01, Abhijit Menon-Sen Wrote
>
> I've changed this to use %zu at Álvaro's suggestion. I'll post an
> updated patch after I've finished some (unrelated) refactoring.
I have started reviewing the patch..
1. Patch applied to git head cleanly.
2. Compiled in Linux -- Some warnings same as mentioned by furuyao
3. Some compilation error in windows
.\contrib\pg_xlogdump\pg_xlogdump.c(1002) : error C2065: 'optional_argument' : undeclared identifier
.\contrib\pg_xlogdump\pg_xlogdump.c(1002) : error C2099: initializer is not a constant
optional_argument should be added to getopt_long.h file for windows.
Please fix these issues and send the updated patch..
I will continue reviewing the patch..
Regards,
Dilip
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2014-06-30 05:34:53 | Re: better atomics - v0.5 |
| Previous Message | Abhijit Menon-Sen | 2014-06-30 05:00:11 | Re: pg_resetxlog to clear backup start/end locations. |