From: | Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec> |
---|---|
To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
Cc: | KaiGai Kohei <kaigai(at)kaigai(dot)gr(dot)jp>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [PATCH] Largeobject access controls |
Date: | 2009-09-28 06:39:27 |
Message-ID: | 3073cc9b0909272339p1154424ei5e64eb73ddfa3d83@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2009/9/24 KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>:
> The attached patch is revised from the previous revision at the following points:
>
> - The "largeobject_compat_acl" is renamed to "largeobject_check_acl".
> Its default is on, and turning it off means the largeobject stuff
> performs in compatible mode for the v8.4.x or prior releases.
> - Notification messages were eliminated at the compatible mode.
> It always allows to bypass ACL checks without any warnings.
>
a few minor points:
+ For example, the <literal>lo_import()</literal> and
+ <literal>lo_export</literal> need superuser privileges independent
+ from this setting, as if the prior version doing.
that should read "as prior versions were doing"?
and you're still using pg_largeobject_meta in some comments in
src/include/catalog/pg_largeobject_metadata.h
besides that it looks good to me...
i will mark the patch as "ready for committer"
--
Atentamente,
Jaime Casanova
Soporte y capacitación de PostgreSQL
Asesoría y desarrollo de sistemas
Guayaquil - Ecuador
Cel. +59387171157
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2009-09-28 07:14:30 | Re: Lock Wait Statistics (next commitfest) |
Previous Message | Brendan Jurd | 2009-09-28 05:45:19 | Re: CREATE LIKE INCLUDING COMMENTS and STORAGES |