| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: changeset generation v5-01 - Patches & git tree |
| Date: | 2013-07-07 19:43:17 |
| Message-ID: | 21269.1373226197@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> 3b) Add catcache 'filter' that ensures the cache stays unique and use
> that for the mapping
> I slightly prefer 3b) because it's smaller, what's your opinions?
This is just another variation on the theme of kluging the catcache to
do something it shouldn't. You're still building a catcache on a
non-unique index, and that is going to lead to trouble.
(I'm a bit surprised that there is no Assert in catcache.c checking
that the index nominated to support a catcache is unique ...)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robins Tharakan | 2013-07-07 19:47:46 | Re: Add regression tests for DISCARD |
| Previous Message | Peter Eisentraut | 2013-07-07 19:40:10 | Re: [PATCH] Add session_preload_libraries configuration parameter |