| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Robert Haas <rhaas(at)postgresql(dot)org> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Avoid GatherMerge crash when there are no workers. |
| Date: | 2017-04-01 02:26:05 |
| Message-ID: | 20170401022605.4wag26gtyzhny7ue@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2017-04-01 01:22:14 +0000, Robert Haas wrote:
> Avoid GatherMerge crash when there are no workers.
I think the gather merge code needs a bit more test coverage (sorry to
make this a larger theme today). As shown by
https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html
we don't actually merge anything (heap_compare_slots is not exercised).
I btw also wonder if it's good that we have a nearly identical copy of
heap_compare_slots and a bunch of the calling code in both
nodeMergeAppend.c and nodeGatherMerge.c. On the other hand, it's not
heavily envolving code.
- Andres
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kevin Grittner | 2017-04-01 04:24:25 | pgsql: Add infrastructure to support EphemeralNamedRelation references. |
| Previous Message | Robert Haas | 2017-04-01 01:22:14 | pgsql: Avoid GatherMerge crash when there are no workers. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2017-04-01 02:29:38 | Re: TPC-H Q20 from 1 hour to 19 hours! |
| Previous Message | Andres Freund | 2017-04-01 02:19:28 | Re: logical replication launcher crash on buildfarm |