| From: | Christian Kruse <christian(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Subject: | Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication |
| Date: | 2014-02-21 13:04:51 |
| Message-ID: | 20140221130451.GC27024@defunct.ch |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 21/02/14 13:49, Andres Freund wrote:
> If we're going this route - which I am ok with - I'd suggest for doing
> something like:
>
> > - PgBackendStatus *be = pgstat_fetch_stat_beentry(i);
> > + LocalPgBackendStatus *lbe = pgstat_fetch_stat_local_beentry(i);
> > + PgBackendStatus *be = &lb->backendStatus;
>
> There seems little point in making all those lines longer and the
> accompanying diff noise if all it costs is a local variable.
>
> Makes sense?
Makes sense, good idea. Attached you will find a new version of the
patch.
Best regards,
--
Christian Kruse http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| xid_and_xmin_in_pg_stat_activity_and_pg_stat_replication_v8.patch | text/x-diff | 13.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christian Kruse | 2014-02-21 13:15:09 | Re: Patch: show xid and xmin in pg_stat_activity and pg_stat_replication |
| Previous Message | Szymon Guz | 2014-02-21 12:53:01 | Re: Storing the password in .pgpass file in an encrypted format |