From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: gistchoose vs. bloat |
Date: | 2012-12-08 15:05:09 |
Message-ID: | 20121208150509.GC15668@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2012-11-02 12:54:33 +0400, Alexander Korotkov wrote:
> On Sun, Oct 21, 2012 at 11:03 AM, Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> > On Thu, 2012-10-18 at 15:09 -0300, Alvaro Herrera wrote:
> > > Jeff, do you think we need more review of this patch?
> >
> > In the patch, it refers to rd_options without checking for NULL first,
> > which needs to be fixed.
> >
> > There's actually still one place where it says "id" rather than "is".
> > Just a nitpick.
> >
> > Regarding my point 4 from the previous email, I mildly disagree with the
> > style, but I don't see a correctness problem there.
> >
> > If the first two items are fixed, then the patch is fine with me.
> >
>
> First two items are fixed in attached version of the patch.
So the patch is ready for committer now?
I notice there's no documentation about the new reloption at all?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2012-12-08 15:08:38 | Re: Statistics and selectivity estimation for ranges |
Previous Message | Andres Freund | 2012-12-08 14:55:12 | Re: Support for REINDEX CONCURRENTLY |