| From: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Leonardo F <m_lists(at)yahoo(dot)it> |
| Cc: | Josh Kupershmidt <schmiddy(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: I: About "Our CLUSTER implementation is pessimal" patch |
| Date: | 2010-07-06 07:52:27 |
| Message-ID: | 20100706165226.9734.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Leonardo F <m_lists(at)yahoo(dot)it> wrote:
> Attached the updated patch (should solve a bug) and a script.
I reviewed your patch. It seems to be in good shape, and worked as
expected. I suppressed a compiler warning in the patch and cleaned up
whitespaces in it. Patch attached.
I think we need some documentation for the change. The only downside
of the feature is that sorted cluster requires twice disk spaces of
the target table (temp space for disk sort and the result table).
Could I ask you to write documentation about the new behavior?
Also, code comments can be improved; especially we need better
description than "copy&paste from FormIndexDatum".
Regards,
---
Takahiro Itagaki
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| sorted_cluster-20100706.patch | application/octet-stream | 24.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Leonardo F | 2010-07-06 09:31:39 | Re: I: About "Our CLUSTER implementation is pessimal" patch |
| Previous Message | KaiGai Kohei | 2010-07-06 07:22:14 | Bug? Concurrent COMMENT ON and DROP object |