| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: CREATE LIKE INCLUDING COMMENTS and STORAGES |
| Date: | 2009-10-05 02:34:40 |
| Message-ID: | 20091005091632.9CD3.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> I'm wondering why we are not
> copying comments on cloned indexes. I realize that might involve a bit
> more code, but I think I'd feel happier if we cloned all the comments we
> reasonably could from the outset. Is it really that hard to do?
I found it is not so difficult as I expected; patch attached. Now it copies
comments on indexes and columns of the indexes on INCLUDING COMMENTS.
Regression test and documentation are also adjusted. Please review around
chooseIndexName() and uses of it.
The codes becomes a bit complex and might be ugly because we will have some
duplicated codes; "pg_expression_%d" hacks and uses of ChooseRelationName()
are spread into index.c, indexcmds.c and parse_utilcmd.c.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| create-including_20091005.patch | application/octet-stream | 40.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Itagaki Takahiro | 2009-10-05 02:46:45 | dblink memory leak |
| Previous Message | Fujii Masao | 2009-10-05 02:28:17 | Re: 8.5 TODO: any info on "Create dump tool for write-ahead logs..." in PITR section (1.4)? |