| From: | Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Greg Smith <gsmith(at)gregsmith(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: multi-threaded pgbench |
| Date: | 2009-07-24 01:17:42 |
| Message-ID: | 20090724101248.93DD.52131E4D@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Itagaki Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
> Greg Smith <gsmith(at)gregsmith(dot)com> wrote:
> > That second code path, when --enable-thread-safety is turned off, crashes
> > and burns on my Linux system:
>
> It comes from confliction of identifiers.
> Renaming identifiers with #define can solve the errors:
> #define pthread_t pg_pthread_t
Here is a patch to fix compile errors by identifier-renaming
when thread-safety is disabled on linux.
Also I fixed file descriptor leaks at the end of benchmark.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-mt_20090724.patch | application/octet-stream | 39.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2009-07-24 01:21:01 | Re: When is a record NULL? |
| Previous Message | Jeff Davis | 2009-07-24 01:06:32 | Re: When is a record NULL? |