Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])
- From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
- To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
- Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
- Subject: Re: [PATCHES] Removing typename from A_Const (was: Empty arrays with ARRAY[])
- Date: Mon, 28 Apr 2008 17:01:25 -0400
- Message-id: <20080428210125.GI5761@alvh.no-ip.org> <text/plain>
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > I came up with the attached patch.
>
> I wasn't envisioning anything anywhere near this invasive. We only
> need locations on constants in a few contexts, I think.
Aha. OK, I'll commit the original patch and let you deal with the rest
of it :-)
> BTW, you broke _equalAConst() ... it was a bad idea anyway to recast
> it on the assumption that there would never again be more than one
> field.
Oops, sorry, I had intended to revert that part and forgot.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
Home |
Main Index |
Thread Index