From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
---|---|
To: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: plpgsql: open for execute - add USING clause |
Date: | 2010-01-13 08:05:35 |
Message-ID: | 162867791001130005l34e5e686l9b1d3a7984765a9d@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
2010/1/12 Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>:
> Hi, I'm reviewing OPEN FOR EXECUTE USING patch and have a couple of
> trivial comments.
>
> Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>
>> this small patch add missing USING clause to OPEN FOR EXECUTE statement
>> + cleaning part of exec_stmt_open function
>
> - Can we use read_sql_expression2() instead of read_sql_construct()
> in gram.y? It could simplify the code a bit.
>
> - I'd prefer to change the new argument for exec_dynquery_with_params()
> from "char *portalname" to "const char *curname".
>
ok, I accept all comments.
revised version are attached.
Thank you,
Pavel Stehule
> Other than the above minor issues, this patch is ready to commit.
>
> Regards,
> ---
> Takahiro Itagaki
> NTT Open Source Software Center
>
>
>
Attachment | Content-Type | Size |
---|---|---|
openexecusing-after-rev.diff | application/octet-stream | 11.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Boszormenyi Zoltan | 2010-01-13 08:22:28 | Re: ECPG patch causes warning |
Previous Message | Michael Meskes | 2010-01-13 07:51:43 | Re: ECPG patch causes warning |