Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code

From: Alexey Vasiliev <leopard_ne(at)inbox(dot)ru>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Patch: add recovery_timeout option to control timeout of restore_command nonzero status code
Date: 2014-12-26 18:42:13
Message-ID: 1419619333.778631968@f256.i.mail.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks for suggestions.

Patch updated.

Mon, 22 Dec 2014 12:07:06 +0900 от Michael Paquier <michael(dot)paquier(at)gmail(dot)com>:
>On Tue, Nov 4, 2014 at 6:25 AM, Alexey Vasiliev < leopard_ne(at)inbox(dot)ru > wrote:
>> Added new patch.
>Seems useful to me to be able to tune this interval of time.
>
>I would simply reword the documentation as follows:
>If <varname>restore_command</> returns nonzero exit status code, retry
>command after the interval of time specified by this parameter.
>Default value is <literal>5s</>.
>
>Also, I think that it would be a good idea to error out if this
>parameter has a value of let's say, less than 1s instead of doing a
>check for a positive value in the waiting latch. On top of that, the
>default value of restore_command_retry_interval should be 5000 and not
>0 to simplify the code.
>--
>Michael
>
>
>--
>Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
>To make changes to your subscription:
>http://www.postgresql.org/mailpref/pgsql-hackers

--
Alexey Vasiliev

Attachment Content-Type Size
=?UTF-8?B?MDAwMS1hZGQtcmVjb3ZlcnlfdGltZW91dC10by1jb250cm9sbC10aW1lb3V0?= =?UTF-8?B?LWJldHdlZW4tcmVzLnBhdGNo?= application/x-patch 4.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Volkov 2014-12-26 18:45:32 Re: BUG #12330: ACID is broken for unique constraints
Previous Message Kevin Grittner 2014-12-26 18:38:01 Re: BUG #12330: ACID is broken for unique constraints