[PATCH] pg_upgrade: Split off pg_fatal() from pg_log()

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: [PATCH] pg_upgrade: Split off pg_fatal() from pg_log()
Date: 2013-09-13 02:50:42
Message-ID: 1379040642.8575.6.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The experiences with elog() and ereport() have shown that having one
function that can return or not depending on some log level parameter
isn't a good idea when you want to communicate well with the compiler.
In pg_upgrade, there is a similar case with the pg_log() function.
Since that isn't a public API, I'm proposing to change it and introduce
a separate function pg_fatal() for those cases where the calls don't
return.

Attachment Content-Type Size
0001-pg_upgrade-Split-off-pg_fatal-from-pg_log.patch text/x-patch 50.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2013-09-13 03:21:10 Re: getting rid of maintainer-check
Previous Message wangshuo 2013-09-13 02:03:44 Re: ENABLE/DISABLE CONSTRAINT NAME