| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Florian Pflug <fgp(at)phlo(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Range Types - typo + NULL string constructor |
| Date: | 2011-10-02 19:05:31 |
| Message-ID: | 1317582331.1724.43.camel@jdavis |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, 2011-10-02 at 11:32 +0200, Florian Pflug wrote:
> Looking at the patch, I noticed that it's possible to specify the default
> boundaries ([], [), (] or ()) per individual float type with the
> DEFAULT_FLAGS clause of CREATE TYPE .. AS RANGE. I wonder if that doesn't
> do more harm then good - it makes it impossible to deduce the meaning of
> e.g. numericrange(1.0, 2.0) without looking up the definition of numericrange.
>
> I suggest we pick one set of default boundaries, ideally '[)' since that
> is what all the built-in canonization functions produce, and stick with it.
Done.
Also, made the range parsing even more like records with more code
copied verbatim. And fixed some parsing tests along the way.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| rangetypes-20111002.gz | application/x-gzip | 48.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2011-10-02 19:07:53 | build times |
| Previous Message | Dimitri Fontaine | 2011-10-02 17:38:40 | Re: pg_cancel_backend by non-superuser |