| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: ALTER TYPE extensions |
| Date: | 2010-09-21 20:17:59 |
| Message-ID: | 1285100279.5468.33.camel@vanquo.pezone.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On tis, 2010-09-21 at 17:53 +0900, KaiGai Kohei wrote:
> Sorry, I missed a bug when we create a typed table using composite
> type which has been altered.
> Perhaps, we also need to patch at transformOfType() to
> skip attributes with attisdropped.
Fixed.
> An additional question. It seems me we can remove all the attributes
> from the composite type, although CREATE TYPE prohibits to create
> a composite type without any attribute.
> What does it mean a composite type with no attribute?
> Or, do we need a restriction to prevent the last one attribute?
We need to allow the creation of zero-attribute types then; same as with
CREATE TABLE. I have fixed that now.
| Attachment | Content-Type | Size |
|---|---|---|
| alter-type-v3.patch | text/x-patch | 40.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2010-09-21 20:23:45 | Re: .gitignore files, take two |
| Previous Message | Magnus Hagander | 2010-09-21 20:17:57 | Re: .gitignore files, take two |