| From: | Andy Balholm <andy(at)balholm(dot)com> |
|---|---|
| To: | Kevin Grittner <Kevin(dot)Grittner(at)wicourts(dot)gov> |
| Cc: | <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: dividing money by money |
| Date: | 2010-06-21 21:07:14 |
| Message-ID: | 07CD1302-559F-470E-8D6A-CB57C5625ED3@balholm.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-www |
On Jun 21, 2010, at 11:47 AM, Kevin Grittner wrote:
> Yes, although the line endings are Windows format (CR/LF).
The line endings must have gotten changed in transit. My original diff used just LF. I made it on a Mac.
> The only issue is with the general guideline to make the new code
> blend in with existing code:
>
> http://wiki.postgresql.org/wiki/Submitting_a_Patch
>
> | Generally, try to blend in with the surrounding code.
>
> | Comments are for clarification not for delineating your code from
> | the surroundings.
>
> There are comments to set off the new code, and some of the new DATA
> lines (and similar) are separated away from where one would expect
> them to be if they had been included with the rest. Moving a few
> lines and deleting a few comment lines would resolve it.
I deleted the excess comments and moved some lines around. Here it is with the changes.
| Attachment | Content-Type | Size |
|---|---|---|
| dividing-money.diff | application/octet-stream | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2010-06-21 21:20:31 | Re: Using multidimensional indexes in ordinal queries |
| Previous Message | Peter Eisentraut | 2010-06-21 20:48:00 | Re: server authentication over Unix-domain sockets |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2010-06-22 05:02:17 | pg_foundry cvs down |
| Previous Message | Kevin Grittner | 2010-06-21 18:47:04 | Re: dividing money by money |