| From: | "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Robert Haas'" <robertmhaas(at)gmail(dot)com> |
| Cc: | "'Craig Ringer'" <craig(at)2ndquadrant(dot)com>, "'Simon Riggs'" <simon(at)2ndquadrant(dot)com>, "'Fujii Masao'" <masao(dot)fujii(at)gmail(dot)com>, "'Craig Ringer'" <ringerc(at)ringerc(dot)id(dot)au>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP patch: add (PRE|POST)PROCESSOR options to COPY |
| Date: | 2012-11-22 12:10:08 |
| Message-ID: | 008801cdc8aa$5062cc20$f1286460$@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> > The biggest problem this patch has had from the very beginning is
> > overdesign, and this is more of the same. Let's please just define the
> > feature as "popen, not fopen, the given string" and have done. You can
> > put all the warning verbiage you want in the documentation. (But note
> > that the server-side version would be superuser-only in any flavor of
> > the feature.)
>
> Agreed. I'll reimplement the feature using the PROGRAM keyword:
>
> > COPY TABLE FROM PROGRAM 'command line';
> > COPY TABLE TO PROGRAM 'command line';
I've reimplemented the feature. Attached is an updated version of the patch.
Todo:
* More documents
* More tests
Any comments are welcomed.
Thanks,
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| copy-popen-20121122.patch | application/octet-stream | 33.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2012-11-22 12:25:35 | Re: Switching timeline over streaming replication |
| Previous Message | Magnus Hagander | 2012-11-22 11:44:27 | Re: PQconninfo function for libpq |