| From: | Hari Babu <haribabu(dot)kommi(at)huawei(dot)com> |
|---|---|
| To: | "'Greg Smith'" <greg(at)2ndQuadrant(dot)com>, "'Amit Kapila'" <amit(dot)kapila(at)huawei(dot)com> |
| Cc: | "'Mike Blackwell'" <mike(dot)blackwell(at)rrd(dot)com>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Performance Improvement by reducing WAL for Update Operation |
| Date: | 2013-07-19 05:10:01 |
| Message-ID: | 007f01ce843e$394512f0$abcf38d0$@kommi@huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Friday, July 19, 2013 4:11 AM Greg Smith wrote:
>On 7/9/13 12:09 AM, Amit Kapila wrote:
>> I think the first thing to verify is whether the results posted can be validated in some other environment setup by another person.
>> The testcase used is posted at below link:
>> http://www.postgresql.org/message-id/51366323.8070606@vmware.com
>That seems easy enough to do here, Heikki's test script is excellent.
>The latest patch Hari posted on July 2 has one hunk that doesn't apply
>anymore now.
The Head code change from Heikki is correct.
During the patch rebase to latest PG LZ optimization code, the above code change is missed.
Apart from the above changed some more changes are done in the patch, those are.
1. corrected some comments in the code
2. Added a validity check as source and history length combined cannot be more than or equal to 8192.
Thanks for the review, please find the latest patch attached in the mail.
Regards,
Hari babu.
| Attachment | Content-Type | Size |
|---|---|---|
| pglz-with-micro-optimization-compress-using-newdata-3.patch | application/octet-stream | 37.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-07-19 05:27:41 | Re: [HACKERS] getting rid of SnapshotNow |
| Previous Message | Amit Kapila | 2013-07-19 04:58:24 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review]) |