Re: Patch for removng unused targets

From: "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: "'Tom Lane'" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "'Alexander Korotkov'" <aekorotkov(at)gmail(dot)com>
Cc: "'pgsql-hackers'" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch for removng unused targets
Date: 2013-06-18 07:30:57
Message-ID: 005d01ce6bf5$c611fbf0$5235f3d0$@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Alexander,

I wrote:
> > From: Tom Lane [mailto:tgl(at)sss(dot)pgh(dot)pa(dot)us]

> > resjunk means that the target is not supposed to be output by the query.
> > Since it's there at all, it's presumably referenced by ORDER BY or GROUP
> > BY or DISTINCT ON, but the meaning of the flag doesn't depend on that.

> > What you would need to do is verify that the target is resjunk and not
> > used in any clause besides ORDER BY. I have not read your patch, but
> > I rather imagine that what you've got now is that the parser checks this
> > and sets the new flag for consumption far downstream. Why not just make
> > the same check in the planner?

> I've created a patch using this approach.

I've rebased the above patch against the latest head. Could you review the
patch? If you have no objection, I'd like to mark the patch "ready for
committer".

Thanks,

Best regards,
Etsuro Fujita

Attachment Content-Type Size
unused-targets-20130618.patch application/octet-stream 3.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Gould 2013-06-18 07:52:57 Re: Spin Lock sleep resolution
Previous Message Heikki Linnakangas 2013-06-18 07:09:55 Re: Spin Lock sleep resolution